Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to connect postgresql in a passwordless mode and with a unix socket #584

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

Psycojoker
Copy link
Collaborator

Before that, it was only possible to connect pyaleph to postgresql using an ip/domain and only with a password.

I've also fix a bug in the tests that was overwriting some configuration.

This PR has been extracted from #574

This PR can be "rebase and merge" since all commits are standalone.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.37%. Comparing base (fc27cb6) to head (e4cd809).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files          91       91           
  Lines        4909     4909           
  Branches      677      677           
=======================================
  Hits         4633     4633           
  Misses        241      241           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@philogicae philogicae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Psycojoker Psycojoker merged commit 3a32f9a into main Jul 30, 2024
6 checks passed
@Psycojoker Psycojoker deleted the small-fixes branch July 30, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants