Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mw privacy manifest ilias 2 #540

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Conversation

nop33
Copy link
Member

@nop33 nop33 commented Apr 25, 2024

  1. I first run pnpm dlx expo prebuild --clean which created this diff: adca479. Here I explain my concerns regarding this diff: Privacy manifest #534 (comment). So, I picked only the changes that I thought were necessary into the first commit of this PR.
  2. Then I replaced the local path with a relative one, manually, into the second commit
  3. Then I run pod install and I noticed that it removed the double quotes from the local path (that's a good sign?) into the 3rd commit.

My remaining concerns are still there:

  1. How do we avoid re-adding by accident the local file when we run prebuild? We need to be careful until hopefully a future version of expo fixes it.
  2. We should try updating our deps and testing to see whether the privacy manifest is still needed.

Copy link

changeset-bot bot commented Apr 25, 2024

⚠️ No Changeset found

Latest commit: c20c670

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nop33 nop33 requested a review from mvaivre April 25, 2024 04:16
@nop33 nop33 marked this pull request as ready for review April 25, 2024 04:18
@nop33
Copy link
Member Author

nop33 commented Apr 25, 2024

This is what I get when I try to run the app...

image

EDIT: After deleting the app and launching it again, it seems to work:

image

@nop33
Copy link
Member Author

nop33 commented Apr 25, 2024

To make sure the above is not an issue, I uninstalled the app, checked out @alephium/mobile-wallet@1.0.9, installed the app, created a wallet, checked out this branch, and launched the app again. It seems to work, I don't get the blank screen anymore.

@nop33
Copy link
Member Author

nop33 commented Apr 25, 2024

I tried to submit an app on TestFlight to see if we get the email again, but I had to update the version number to 1.0.10 first. Tryign again...

@nop33 nop33 merged commit 6aa77da into MW-privacy-manifest Apr 25, 2024
6 checks passed
@nop33 nop33 deleted the MW-privacy-manifest-ilias-2 branch October 7, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants