Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Sentry in mobile wallet #888

Closed
wants to merge 14 commits into from
Closed

Set up Sentry in mobile wallet #888

wants to merge 14 commits into from

Conversation

nop33
Copy link
Member

@nop33 nop33 commented Oct 16, 2024

Trying to debug:

Most of the diff is auto-generated after installing Sentry and running the wizard.

Also run expo-doctor to clean up some deps versions, as advised by our AI friends here: #865

@nop33 nop33 requested a review from mvaivre October 16, 2024 11:25
Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 71e8425

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@mvaivre mvaivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👁️

@@ -91,4 +91,4 @@
<key>UIViewControllerBasedStatusBarAppearance</key>
<false/>
</dict>
</plist>
</plist>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird, there are multiple new lines EOF across the PR, but I guess we don't care :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, cause the sentry wizard edited these files.

@nop33 nop33 requested a review from mvaivre October 17, 2024 08:45
@nop33
Copy link
Member Author

nop33 commented Oct 17, 2024

Closing in favor of:

@nop33 nop33 closed this Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants