Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename build.ralph to ralph.json #39

Closed
simerplaha opened this issue Oct 16, 2023 · 3 comments · Fixed by #70
Closed

Rename build.ralph to ralph.json #39

simerplaha opened this issue Oct 16, 2023 · 3 comments · Fixed by #70

Comments

@simerplaha
Copy link
Member

simerplaha commented Oct 16, 2023

Initial assumption was that a custom file extension was required for the clients to narrow down the files to trigger file change events, but this is not the case.

Use .json so that that editor's default JSON support gets enabled.

@simerplaha
Copy link
Member Author

simerplaha commented Nov 14, 2023

Better to use a file name that is not tied to a specific file format.

Users can add file association instead.

In VSCode add the following to settings.json.

"files.associations": {
    "*.ralph": "json"
}

@simerplaha simerplaha added the status:wontfix This will not be worked on label Nov 14, 2023
@simerplaha simerplaha reopened this Nov 21, 2023
@simerplaha
Copy link
Member Author

simerplaha commented Nov 21, 2023

Hey @tdroxler, what do you think of this issue?

I'm not too sure. The rust link you shared here showed that they use rust-project.json.

I don't know 😕. If we use ralph.json now and also want to support ralph.toml in the future, we could. But with build.ralph we might be a bit more restricted to a single format, unless we do fancy parsing to detect format.

@tdroxler
Copy link
Member

yeah I would favor ralph.json more, as you said:

Use .json so that that editor's default JSON support gets enabled.

is a big plus, editor usually come with a linter etc and we don't know for all editors if we can configure the same way as vscode.

simerplaha added a commit that referenced this issue Nov 22, 2023
@simerplaha simerplaha removed the status:wontfix This will not be worked on label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants