Rename (remaining cases)

[simerplaha]

• Resolves Renaming should apply to all occurrences, not just the current member's scope #318
• Resolves Renaming an inherited function should also rename its implementations #315
• Renaming still uses go-to-references for search. So renaming should work on all node types that have go-to-reference implemented.
• Handles cases that are specific to renaming. These cases can be found in test-cases within the rename package. In short, they ensure that renaming does not change the state of the program, i.e., renaming should not result in additional errors. For example, in the following case, renaming an abstract function should also rename its implementation and not result in an unimplemented function error.

  Abstract Contract Parent() {
    fn >>function@@<<() -> ()
  }
  
  Contract Child() extends Parent() {
    fn >>function<<() -> () { }
  }

[tdroxler]

Nice job, renaming seems very complicated 😅

[simerplaha]

I will try to simplify it and will add more documentation. Rename is the smallest of all CodeProviders. It recursively calls go-to-references on all references, which results in the nodes to rename.

[tdroxler]

I will try to simplify it and will add more documentation. Rename is the smallest of all CodeProviders. It recursively calls go-to-references on all references, which results in the nodes to rename.

I was more thinking of the complexity of thinking to every edge cases, code wise it's indeed smaller and quite clear

[simerplaha]

Oh yes! Complicated for sure. Initially the thought was that it would be as simple as calling go-to-references. These edge cases popped up in my head at random hours through the day.