Fix some composite Hebrew glyphs #556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
previously approved these changes
Sep 23, 2024
|
Totally forgot about normalize. I hope I have done it correctly. |
You did the right thing, but with some older bit of software. Either I can't push it here because you opened this PR from your master branch, but I did merge it. In the future if you create a new branch to work on any changes GitHub will make it a little easier to collaborate because I would be able to push directly to the PR and in the end your PR would show as "merged" instead of "closed", but again not a huge deal. Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Serif Italic there were errors with some composite Hebrew fonts. Bold Italic is fine. This request fixes the issue.