Add Support for Distance Probes #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Super-duper basic implementation of Wwise Distance Probes. Requires the Game Objects used to have already been registered as a listener and an object respectively.
Added the methods to the Wwise GDExtension documentation.
|
Thank you! (2+ thanks for updating the provided documentation. This should be visible in-editor in 4.3). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy!
I recently used your implementation of Wwise in Godot for a game jam, and noticed there was no support for Distance Probes, such that 3rd person audio was sometimes a little funky. The Wwise API docs made it look pretty straightforward, so I added it myself by essentially copying the existing code for Register Listener and Register Game Object.
From my personal testing this works as expected, but I'm not deeply familiar with the Wwise API or programming for production use, so I've probably missed some error checking somewhere and haven't run any of the presumably standard tests/analysis. Additionally, I couldn't figure out how to easily get the current Listener Game Object, so I wasn't able to make custom nodes that would act as distance probes themselves.
Please consider this pull request, or otherwise just copying and fixing my code for inclusion in the next release! :)