Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share libraries/collections publicly to all users (including unauthenticated ones) #48

Open
4 tasks done
dylanvorster opened this issue Jun 25, 2023 · 1 comment
Open
4 tasks done
Labels
enhancement New feature or request

Comments

@dylanvorster
Copy link

Describe your suggested feature

I think the reach of this project would spread much further if there was a way to mark various collections as public. This would allow users to host a sort of public-gallery of their book collections. I myself have many art books and want to showcase the collection to my friends (or anyone who visits my site) as they can also get a better idea of my interests etc..

One way to hack this with MVP, might be to provide an environment variable which makes the 'get' / read routes and pages public, but still disables any post or put requests. Obviously long term it could be neat to mark collections as public and/or provide a shareable public URL.

I know theres a ton of other stuff you still working on but also wanted to just say well-done, even in this early stage of the project its very fleshed out and was super easy to run with docker.

Other details

This project is super polished and incredibly well engineered. How you only have like 5 stars is beyond me >_>

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have updated the app to the latest version.
  • I filled out all of the requested information in this form.
@dylanvorster dylanvorster added the triage Issues to be reviewed label Jun 25, 2023
@alessandrojean
Copy link
Owner

Thanks for the feedback!

Being able to share your library publicly (or even only parts of it) is something I pretend implementing eventually, but it's not something I plan to add in the first major stable release since it would require a lot of changes. I have this exact same use case need as well, so I get your suggestion.

Currently, the server already supports a similar feature by allowing libraries to be shared to other users (always with writing permissions as well -- still needs improvements), but the user picker is still needed to be added in the client while editing a library. It just needs to be improved by allowing a Public/Private chooser, similar to how Google Drive does with file sharing.

Thanks for testing the Docker image as well, glad it worked for you. :)

@alessandrojean alessandrojean added enhancement New feature or request and removed triage Issues to be reviewed labels Jun 25, 2023
@alessandrojean alessandrojean changed the title Public pages for Books / Collections / Libraries or some way to make the site read-only for public viewing. Share libraries/collections publicly to all users (including unauthenticated ones) Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants