Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

type constraints validate ScalarValue and return valid Datum #316

Merged
merged 3 commits into from
Sep 13, 2020

Conversation

alex-dukhno
Copy link
Owner

@alex-dukhno alex-dukhno commented Sep 13, 2020

Closes #310 #218

Description

type constraints validate ScalarValue and return valid Datum

Client output

No changes to client output

@coveralls
Copy link

coveralls commented Sep 13, 2020

Pull Request Test Coverage Report for Build 252721346

  • 312 of 319 (97.81%) changed or added relevant lines in 8 files are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 88.401%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/query_planner/src/planner/update.rs 4 5 80.0%
src/query_planner/src/planner/insert.rs 8 10 80.0%
src/constraints/src/lib.rs 267 271 98.52%
Files with Coverage Reduction New Missed Lines %
src/sql_engine/src/dml/insert.rs 1 65.67%
src/ast/src/lib.rs 16 46.96%
Totals Coverage Status
Change from base Build 252403339: 0.4%
Covered Lines: 7576
Relevant Lines: 8570

💛 - Coveralls

@alex-dukhno alex-dukhno linked an issue Sep 13, 2020 that may be closed by this pull request
@alex-dukhno alex-dukhno merged commit dd6d413 into master Sep 13, 2020
@alex-dukhno alex-dukhno deleted the Constraint-Validation-API-changes branch September 13, 2020 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constraint Validation API changes Datum construction from incoming data from client
2 participants