Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashes with partial RawStrings #146

Closed
jandamm opened this issue Apr 2, 2022 · 1 comment · Fixed by #150
Closed

Crashes with partial RawStrings #146

jandamm opened this issue Apr 2, 2022 · 1 comment · Fixed by #150

Comments

@jandamm
Copy link

jandamm commented Apr 2, 2022

I'm using this tree sitter with nvim-treesitter so it's running a lot with incomplete code.

When I'd run it on this snippet it crashes (looks like an infinite loop).

let myText = #"abc"

Which happens when I want to convert a String to a RawString or when starting a RawString.
It works when I'm adding the final # and then the first.

@alex-pinkus
Copy link
Owner

Thanks for filing this. It sounds like the closing condition here is not sufficient but I’ll have to look into it to figure out why. Will try to find some time for that this week.

alex-pinkus added a commit that referenced this issue Apr 20, 2022
Fixes #159

This was the same problem as #146, where there was a `while` loop in the
custom scanner that terminated on newlines but not on EOF. To fix, we
just terminate on EOF for this loop as well.
alex-pinkus added a commit that referenced this issue Apr 20, 2022
Fixes #159

This was the same problem as #146, where there was a `while` loop in the
custom scanner that terminated on newlines but not on EOF. To fix, we
just terminate on EOF for this loop as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants