Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tree-sitter.json for compatibility with newer versions of tree-sitter #443

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Erick2280
Copy link
Contributor

@Erick2280 Erick2280 commented Oct 9, 2024

Hi @alex-pinkus, thanks for the amazing work!

I've noticed that newer versions of tree-sitter (I'm currently using 0.24.2) require a tree-sitter.json file in the root directory, instead of specifying settings under the tree-sitter key in package.json. While running tree-sitter generate automatically migrates to the config file, using this grammar as a npm dependency fails because the tree-sitter.json file is expected to be present.

This PR adds the tree-sitter.json config file. I’ve kept the tree-sitter key in package.json for backwards compatibility with older versions.

@Erick2280 Erick2280 changed the title Generate tree-sitter.json Add tree-sitter.json for compatibility with newer version of tree-sitter Oct 9, 2024
@Erick2280 Erick2280 changed the title Add tree-sitter.json for compatibility with newer version of tree-sitter Add tree-sitter.json for compatibility with newer versions of tree-sitter Oct 9, 2024
@alex-pinkus
Copy link
Owner

Thank you for adding this!

@alex-pinkus alex-pinkus merged commit 26eac68 into alex-pinkus:main Oct 9, 2024
55 checks passed
@Erick2280 Erick2280 deleted the patch-1 branch October 9, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants