Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to more clearly show "Last modified by" #161

Closed
vilhelmprytz opened this issue Feb 29, 2020 · 5 comments
Closed

Ability to more clearly show "Last modified by" #161

vilhelmprytz opened this issue Feb 29, 2020 · 5 comments
Labels
wontfix This will not be worked on

Comments

@vilhelmprytz
Copy link
Contributor

Footer

I might be missing something here, but the only way I can find who was the last person to edit a specific page (i.e. with the enableGitInfo enabled) is to hover over the date ("February 29, 2020" in the picture above). Is there any way to configure the theme to more visibly display who edited the page, and if not, is this something that could be implemented?

Cheers

@alex-shpak
Copy link
Owner

Well, I didn't put it into link to save some space in mobile view.
Simple trick would be to inject extra line into footer with layouts/docs/inject/footer.html and

{{ with .GitInfo }}
<div class="flex justify-end">
  {{ i18n "Last modified by" }} {{ .AuthorName }}
</div>
{{ end }}

image
Tho looks a bit ugly for my taste 🤔

I'm open for changing it if we can find some clean way.

@vilhelmprytz
Copy link
Contributor Author

Hmm, I created the file layouts/docs/inject/footer.html in my project but the "Last modified" does not show up? Is there anything else I have to add?

@vilhelmprytz
Copy link
Contributor Author

vilhelmprytz commented Mar 1, 2020

Oh, I got it. I had to create the file as layouts/partials/docs/inject/footer.html and not layouts/docs/inject/footer.html. I agree that it looks a little bit off, perhaps a little bit smaller and/or italic? (just suggestions)

@alex-shpak
Copy link
Owner

Ah, my bad, I wrote path wrong. You can apply styles you want directly in partial or in assets/_custom.scss. I don't have vision right now how to fit it nicely 🤔

@alex-shpak
Copy link
Owner

Hi!
I gave it some thought, I would like to keep date as it is I think, it is small and simple now. So you will have to customize it for your needs, unfortunately.

@alex-shpak alex-shpak added the wontfix This will not be worked on label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants