-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for Disqus #120
Conversation
Hi! Looks good, thanks for your contribution.
Since It could look like
|
Set: bookDisableComments: true On a page to disable disqus for the content.
Hi @alex-shpak, sorry for the delay, I've been travelling! OK here are the updates:
I don't think I'd fully updated the PR before; there are actually two new configuration fields:
I think this makes sense; it means nothing should change for existing users, they still need to opt-in for disqus, but they can opt-out of pages if it doesn't make sense to have comments for them. Thanks for the heads up on the spacing too - looks much cleaner now! BTW if you'd prefer me to make this a single commit, I can open a new PR with these commits squashed. |
Good, I will add |
Pushed to master. |
Thanks @alex-shpak, I appreciate the patience as I get familiar with the project! |
Looks great @alex-shpak, I think it's much cleaner the way you've structured it, really nice to be able to potential switch out comment systems 😄 |
This PR adds support for Disqus. If the standard Hugo
disqusShortname
configuration is provided, comments will be enabled for pages. This is a non-breaking change, comments are disabled by default.Apologies if I've got something wrong here, am fairly new to Hugo!
Disqus can be disabled for any content by setting the following in the frontmatter:
See effectiive-shell for an example. Disqus is disabled on the main index page, and enabled for each chapter.