Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile toc menu #121

Merged
merged 4 commits into from
Jan 13, 2020
Merged

mobile toc menu #121

merged 4 commits into from
Jan 13, 2020

Conversation

tyler71
Copy link
Contributor

@tyler71 tyler71 commented Jan 6, 2020

This allows the TOC to be visible from smaller devices in the same manner as the menu.

  • Uses Page title as label
  • Label entries so that tapping TOC will hide menu

Unknown added 2 commits January 6, 2020 09:21
Uses Page title as label

Label entries so that tapping TOC will hide menu
@tyler71 tyler71 changed the title TOC menu Mobile TOC menu Jan 6, 2020
@tyler71 tyler71 changed the title Mobile TOC menu mobile toc menu Jan 6, 2020
@alex-shpak
Copy link
Owner

Hi! Thanks for contribution.
I think this solution needs some more thinking. It doesn't work well for mid size screens, like for 700px.
image

Maybe it's better to show ToC at the top of the page 🤔

@tyler71
Copy link
Contributor Author

tyler71 commented Jan 7, 2020

Maybe it's better to show ToC at the top of the page 🤔

My original attempt was to copy the print css you had, which worked.
However, I ran into issues quickly where there were many TOC entries, taking up multiple screens.

A easy fix is simply switching to the mobile format at $md-breakpoint

TOC Above

toc-above

MD Breakpoint

md-breakpoint

tos-menu-control -> toc-control
toc-menu-control -> toc-control
@alex-shpak
Copy link
Owner

👍

@alex-shpak alex-shpak merged commit e037b7c into alex-shpak:master Jan 13, 2020
@tyler71 tyler71 deleted the toc-menu branch January 14, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants