Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's enable markdown in the button title #308

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

raspopov
Copy link
Contributor

Added " | markdownify" to the inner text of button.

Added " | markdownify" to the inner text of button.
@alex-shpak
Copy link
Owner

Hi! Thanks for the PR!

Not sure if adding markdownify is safe enough. when creating that shortcode I started with markdownify but then removed it as it was too easy to break html outout, since markdownify could create block element inside of button.

If you are after styling text in button I can suggest to use CSS classes:

  • create assets/_custom.scss
  • add class with desired styling
  • add class to button shortcode `{{< button class="" >}}

@raspopov
Copy link
Contributor Author

raspopov commented Feb 5, 2021

It's not about styles but possibility of using inner shortcodes.

@alex-shpak
Copy link
Owner

Okay, I will merge PR. Tho, I will have to revert if it will start causing problems.
Perhaps also will be good to add whitespace trimming to .Inner content.

I will write here if I will have to revert it.

@alex-shpak alex-shpak merged commit 27c1791 into alex-shpak:master Feb 19, 2021
@raspopov raspopov deleted the patch-2 branch May 21, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants