Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional brand logo in the menu controlled by .Site.Params.BookLogo #71

Merged
merged 3 commits into from
Sep 5, 2019

Conversation

twohey
Copy link
Contributor

@twohey twohey commented Sep 1, 2019

Without a logo things look the same. With a logo the menu now has a bit of flair:

with-logo

I've added documentation for how to use the logo in the README and the example configurations. I didn't feel comfortable picking a default logo for all sites, so did not add one.

- documentation in README.md and exampleSite/config.{toml,yaml}
@alex-shpak
Copy link
Owner

alex-shpak commented Sep 1, 2019

Thank you, I support your decision to keep theme generic :).
Not sure, maybe it would be nice to have css resizing logo to keep it same size as title. But I can add it later.

@alex-shpak
Copy link
Owner

👍

@alex-shpak alex-shpak merged commit 73e5376 into alex-shpak:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants