-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click on Popup trigger on map click event #725
Comments
I'm not sure what the "correct" behaviour would be here. I suppose the popup click handler's stopPropagation should stop propagation to the map – not sure why it's not the case right now. One option to solve your problem in the meanwhile would be to change your code that closes the popup. Inside the click handler, add an extra check:
|
yeah, but it is only kind of work around, and also don't fix all of problems. |
I can also think of valid use cases where the popover should remain open and the map draggable when dragging on top of it. Still not sure if this is really a bug. Before v4.3.0, there was definitely a bug with markers, at least. |
I would say this isn’t necessarily unintended behavior, but it is a breaking change. Maybe the marker fix really should have gone to v5? Or maybe popups are a special case. What if popups have an option to prevent mouse events propagating to the map and its on by default to avoid a breaking change (e.g. 4.3.1 would go back to previous behavior with an option to pass events through)? |
layers This flag defaulting to `false` brings back the default behaviour from prior to v4.3.0. Fixes alex3165#725
Last update 4.3.0 (probably "Fixed mouse events on Marker and Cluster elements") occurred problem with popups, because click on Popup trigger on map click event, also it is possible to drag map by clicking on popup
It is really problematic when you fire hide popup action after clicking on map.
In previous library version everything is ok.
The text was updated successfully, but these errors were encountered: