Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update listeners when event props change #820

Merged
merged 5 commits into from
May 20, 2020

Conversation

sanfilippopablo
Copy link
Contributor

The code right now checks:

  • If there was a listener and got removed, then unlisten from the map.
  • If there wasn't a listener before and one was added to the props, add it to the map.
    But it's not checking if the listener simply changed. This fixes that issue, making the map be always up to date with the listeners passed through props.

@olso
Copy link

olso commented Apr 16, 2020

@alex3165 @mklopets

@dimagimburg
Copy link

Any updates on this? right now I have to manage complicated code using refs everywhere as a workaround.

@mklopets mklopets merged commit 394b555 into alex3165:master May 20, 2020
@mklopets
Copy link
Collaborator

Thanks @sanfilippopablo! Released as v4.8.4

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants