Fixed the year calculation edge case. #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The nextBirthday variable is updated with currentYear +1 but the currentYear variable in itself is not updated. This will lead to an error in the output given by Alexa when the user's birthday is in the next year because the output is generated using year - currentYear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The nextBirthday variable is updated with currentYear +1 but the currentYear variable in itself is not updated. This will lead to an error in the output given by Alexa when the user's birthday is in the next year because the output is generated using year - currentYear.
Description of Change:
Created a new variable called nextYear. It is by default set to currentYear and incremented when a user's birthday exceeds the current time of the year. This nextYear variable is used for age calculation instead of the currentYear variable.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.