fix: deploy skill package when icon uri path relative to its asset files #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsetton
force-pushed
the
file-icon-uri-deploy-fix
branch
from
72a51b1
to
b183a97
Compare
jsetton
force-pushed
the
file-icon-uri-deploy-fix
branch
from
b183a97
to
bc54b34
Compare
jsetton
force-pushed
the
file-icon-uri-deploy-fix
branch
from
bc54b34
to
d86395e
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#251
Description of changes:
The only way to update a skill manifest that includes an icon uri path relative to the skill package asset files (e.g.
file://assets/images/en-US_smallIcon.png) is to deploy it inside a skill package. Otherwise, SMAPI will reject the update skill manifest request for having an invalid url format.This was previously fixed but was removed since 2.29.0. This change is reintroducing the fix with the ability to determine, based on the presence of a file icon uri, when the skill manifest should be deployed part of a skill package or just updated on its own.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.