fix: get skill status should only poll when in progress #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tydonelson
approved these changes
Feb 26, 2024
| empty(statusTracker.interactionModel) || | ||
| empty(statusTracker.hostedSkillProvisioning) || | ||
| // retry if one of manifest, interaction model, provisioning are in progress | ||
| statusTracker.manifest === CONSTANTS.HOSTED_SKILL.MANIFEST_STATUS.IN_PROGRESS || |
There was a problem hiding this comment.
JW do we need three constants for IN_PROGRESS?
Also, I think if we use variables, then we don't need the comments:
const isAllResourcesCreated = [
statusTracker.manifest,
statusTracker.interactionModel,
statusTracker.hostedSkillProvisioning
].every(Boolean)
const isAnyResourceInProgress = [
statusTracker.manifest,
statusTracker.interactionModel,
statusTracker.hostedSkillProvisioning
].includes(Status.IN_PROGRESS)
There was a problem hiding this comment.
I'm not sure if there was some maintainability reason behind separate constants/if they are subject to change, but I agree, it can be collapsed into a single constant. and this does look a lot cleaner! Will update in the next PR, missed your comment.
There was a problem hiding this comment.
oh no worries, it was minor, thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Currently,
ask newcontinues polling for >15 minutes when one of the steps has failed, instead of displaying the error message. This CR will ensure polling occurs when a step is in progress.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.