Feature: docs, test improvement, inline comments #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
alexanderem49
commented
Oct 23, 2023
alexanderem49
commented
- Contracts:
- In line comments
- Tests:
- In line comments
- Improve coverage of integration test
- Documentation
- Component page
- non-upgradable version
- extend description of contract logic and methods imported/exported
- non-upgradable version
- Component page
alexanderem49
force-pushed
the
feature/docs-test-improvement
branch
from
d5b528a
to
6a5f402
Compare
Jorge-Lopes
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Some updates are requested.
The suggestions made to the simpleExchange are related to the upgradableSimpleExchange as well.
It seems to be some confusion on the term seat and offer on both comments and the contract as well. Maybe we should update the contract terminology on this regards.
The component page I will review in more detail in the future
alexanderem49
force-pushed
the
feature/docs-test-improvement
branch
3 times, most recently
from
a6afde6
to
8330be7
Compare
alexanderem49
force-pushed
the
develop
branch
from
d8bc684
to
75b2010
Compare
alexanderem49
force-pushed
the
feature/docs-test-improvement
branch
from
8330be7
to
017bfde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.