Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few small fixes from local testing #5

Conversation

ryantrem
Copy link

I checked out the branch locally to test and found a few small issues, which this PR fixes:

  1. We need to store _skyboxVisible separate from the skybox mesh, since the environment visible flag could be set before a skybox has been loaded (or when switching to a new environment, in which case we should preserve the visibility flag).
  2. Update how we handle the Scene.autoClear flag, such that autoClear is enabled if there is no skybox or if the skybox is not visible.
  3. Wrapped some of the new state mutations in calls to disableSnapshotRendering and enableSnapshotRendering to ensure that the snapshot rendering state is correctly updated (needed for WebGPU).

Fix snapshot rendering
@alexandremottet alexandremottet merged commit d0f764c into alexandremottet:environment-rotation-intensity Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants