A few small fixes from local testing #5
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked out the branch locally to test and found a few small issues, which this PR fixes:
_skyboxVisible
separate from the skybox mesh, since the environment visible flag could be set before a skybox has been loaded (or when switching to a new environment, in which case we should preserve the visibility flag).Scene.autoClear
flag, such that autoClear is enabled if there is no skybox or if the skybox is not visible.disableSnapshotRendering
andenableSnapshotRendering
to ensure that the snapshot rendering state is correctly updated (needed for WebGPU).