tile_num_in_direction can be called with either integer or pointer as the origin argument. Fixes #409 #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the origin argument. Fixes alexbatalov#409 Both variants are used in the ecdogmet.ssl script: ``` tile_num_in_direction(self_tile, Random(0, 5), 1); tile_num_in_direction(dude_obj, Random(0, 5), Random(5, 10)); ```
|
This is a script error and a rare one at that. I don't think the opcode itself should be modified to accommodate one broken script. And in general, it is a bad design to accept a whole object as argument of a function, where you only need one value (tile num). It should accept just the tile, IMO. |
|
Already fixed in the unofficial patch: BGforgeNet/Fallout2_Unofficial_Patch@55a08f4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both variants are used in the ecdogmet.ssl script: