Set hitLocation when return status is not -1 #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've double checked the original binary, there is indeed a bug, the default hit location is torso. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR is here fallout2-ce#9
In some cases function
calledShotSelectHitLocationcan return not a-1value but not to sethitLocation. This causes undefined behavior whenhitLocationis used later, and it can cause the game to crash with segfault becausehitLocationis used as array index later.This PR ensures that if
calledShotSelectHitLocationfunction reports a success thenhitLocationvalue will always be setOriginally reported in https://www.nma-fallout.com/threads/fallout-nevada-and-sonora-in-the-browser.222617/#post-4529005