Fix parameters in tessilator functions #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…limit the number of sectors.
Except for the error messages printed out, these functions were essentially identical (and probably developed by copying and pasting from one to the other). I combined them back into one function, so that we don't have to maintain them separately. In fact, one of them had an error in it (I think a typo in a variable name) that would have made it fail, if it was ever used (which shows our test coverage was insufficient).
|
Thank you. I'm happy to implement all these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has multipke parts, shown as separate commits that you might want to review separately:
store_lcin the function signature, but then in the code they would not use that value and insteald always call the lower-level function withstore_lc=False).cutour_Xfunctions were unneccessarily complicated. So, instead of makeing all four function signatures consistent, I just integrated all the functionality into a single function.