Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sphinx build again #25

Merged
merged 1 commit into from
May 24, 2024
Merged

Make sphinx build again #25

merged 1 commit into from
May 24, 2024

Conversation

hamogu
Copy link
Contributor

@hamogu hamogu commented May 24, 2024

Since I broke it when I moved from setup.cfg to pyproject.toml

@hamogu hamogu force-pushed the sphinx branch 2 times, most recently from c1a48d6 to adea19b Compare May 24, 2024 14:40
Since I broke it when I moved from setup.cfg to `pyproject.toml`
@hamogu
Copy link
Contributor Author

hamogu commented May 24, 2024

OK, it builds again on RTD, but it does not look good: https://tessilator--25.org.readthedocs.build/en/25/
Some style file is missing somewhere... I'm hunting for it now.

@hamogu
Copy link
Contributor Author

hamogu commented May 24, 2024

I can't find what's missing here. Maybe it's just because this is build on the PR. I suggest merging it and if the RTD looks bad after that, we can go an fix it in a new PR.

@alexbinks
Copy link
Owner

alexbinks commented May 24, 2024 via email

@alexbinks alexbinks merged commit b27ee45 into alexbinks:main May 24, 2024
1 of 3 checks passed
@hamogu hamogu deleted the sphinx branch May 24, 2024 16:15
@hamogu
Copy link
Contributor Author

hamogu commented May 24, 2024

Looks correct here: https://tessilator.readthedocs.io/en/latest/
So it's probably just because they insert the "preview banner" that interacts with the style in some funny way.

@alexbinks
Copy link
Owner

alexbinks commented May 24, 2024 via email

@hamogu
Copy link
Contributor Author

hamogu commented May 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants