Skip to content
This repository has been archived by the owner on Jun 21, 2019. It is now read-only.

url-0.5.9: failed to parse manifest #6

Closed
krig opened this issue Jun 30, 2016 · 4 comments
Closed

url-0.5.9: failed to parse manifest #6

krig opened this issue Jun 30, 2016 · 4 comments

Comments

@krig
Copy link
Contributor

krig commented Jun 30, 2016

Trying to vendor cargo-vendor itself, I'm getting this error:

$ cargo vendor --verbose
 Downloading pnacl-build-helper v1.4.10
 Downloading gdi32-sys v0.2.0
error: unable to get packages from source

Caused by:
  failed to parse manifest at `/home/krig/.cargo/registry/src/git.luolix.top-88ac128001ac3a9a/url-0.5.9/Cargo.toml`

Caused by:
  could not parse input as TOML
/home/krig/.cargo/registry/src/git.luolix.top-88ac128001ac3a9a/url-0.5.9/Cargo.toml:14:3 expected a newline after table definition

error: third party subcommand `cargo-vendor` exited unsuccessfully

To learn more, run the command again with --verbose.
@krig
Copy link
Contributor Author

krig commented Jun 30, 2016

cargo build succeeds without complaint, so there's somehow a difference in how it parses TOML, because it does download and compile url-0.5.9 as well.

@alexcrichton
Copy link
Owner

Ah yeah this is fixed in more recent versions of Cargo (as a library), and this can probably just be fixed by updating dependencies

@krig
Copy link
Contributor Author

krig commented Jul 1, 2016

Something like rust-lang/cargo#2680 is probably the fix that is needed here.

@krig
Copy link
Contributor Author

krig commented Jul 1, 2016

Apologies for the spam here, but for the record I figured it out: Cargo.lock in cargo-vendor has toml 0.1.30 whereas Cargo.lock in the 0.10.0 branch of cargo has toml 0.1.28. Mystery solved, and the fix is simply to roll back to 0.1.28 in cargo-vendor until the next version of cargo is released.

krig added a commit to krig/cargo-vendor that referenced this issue Jul 1, 2016
When cargo 0.10.0 was released the latest version of toml was 0.1.28,
which allows malformed TOML where table entries don't have a newline
between the header and the first key.

Toml 0.1.29 disabled this by default and later versions of cargo pass
a flag to get the compatibility mode.

Until the next version of cargo is released, roll back the toml dependency
for cargo-vendor to 0.1.28 to match the behavior of cargo 0.10.0.

Fixes: alexcrichton#6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants