Disable all debug assertions unless the debug feature is enabled #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several debug assertions are very expensive, causing allocation heavy code to be slowed down by over 100x in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several debug assertions are very expensive, causing allocation heavy code to be slowed down by over 100x in some cases.
The patch here was written by @bjorn3. I can add that I've also observed excessively slow performance in debug builds. It's my impression that the dlmalloc code is written with the assumption that its asserts won't be enabled in practice, even in typical "debug build" scenarios, because users would usually be using a precompiled malloc. But ported to Rust here, it does typically get built from source.