Fix weak-crypto feature #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me, thanks! While you're at it would you be ok inverting the conditional and swapping the cases? (seems a bit easier to read to me at least) |
These flags are disabled by default at least in newer versions of openssl. So They have to be explicitly enabled to be used.
|
Sure thing. Done. |
james58899
pushed a commit
to james58899/openssl-src-rs
that referenced
this pull request
Feb 5, 2022
These flags are disabled by default at least in newer versions of openssl. So They have to be explicitly enabled to be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flags are disabled by default at least in newer versions of openssl.
So They have to be explicitly enabled to be used.
I've verified this behavior on openssl 1.1.1h and 3.0.1. Other flags/features might have the same issue, but I have no check yet.