Use cc for ar/ranlib detection #173
Conversation
|
Marked this as a draft until the cc-rs PR lands. |
|
|
Note that `Command::get_program` and `Command::get_args` both stabilized in Rust 1.57.0, and so implicitly bump this crate's MSRV. Depends on rust-lang/cc-rs#763. Replaces alexcrichton#164.
|
@alexcrichton The features we needed from |
|
Do you have a rough sense for when this may land in a release? I have a couple of builds in semi-weird environments that are currently failing and would be fixed by this :) |
|
I believe an OpenSSL security release is happening next week, so next week. |
|
Interesting — that makes me wonder if we might want to release this now to get a heads up in case it breaks anyone's builds. I worry about getting into a position where a security fix goes out at the same time as a change that may break people's builds, as it may mean some people end up not being able to take the security fix. |
|
Ah, I just realized this only affects the 300 major version. I assume it'd also be okay to backport to 111? I'm happy to do that assuming it's acceptable. |
|
Yes that's fine, I can make a release after a PR to the 111 branch |
Note that `Command::get_program` and `Command::get_args` both stabilized in Rust 1.57.0, and so implicitly bump this crate's MSRV. Depends on rust-lang/cc-rs#763. Backport of alexcrichton#173.
|
Backport to 111 in #180 |
Note that `Command::get_program` and `Command::get_args` both stabilized in Rust 1.57.0, and so implicitly bump this crate's MSRV. Depends on rust-lang/cc-rs#763. Backport of #173.
|
Note this does appear to have broken rustup builds: |
|
I don't know how best to fix this myself, unfortunately. |
|
As per this comment I don't think this is a bug in |
| } | ||
| let ranlib = cc.get_ranlib(); | ||
| configure.env("RANLIB", ranlib.get_program()); | ||
| if ranlib.get_args().count() == 0 { |
There was a problem hiding this comment.
If count is 0, then we set the RANLIBFLAGS to empty string?
Why we need to do that?
There was a problem hiding this comment.
So that we explicitly do not inherit RANLIBFLAGS from upstream if it's been overridden in the environment. At least I think that was the thinking.
Note that
Command::get_programandCommand::get_argsboth stabilized in Rust 1.57.0, and so implicitly bump this crate's MSRV.Depends on rust-lang/cc-rs#763.
Replaces #164.