Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow openssldir to be configured. #220

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Allow openssldir to be configured. #220

merged 1 commit into from
Dec 4, 2023

Conversation

DanielSidhion
Copy link
Contributor

@DanielSidhion DanielSidhion commented Dec 4, 2023

This PR addresses the discussion from #162 given the unresponsiveness of the author of that PR.
It won't directly resolve #161, but once this is merged, a subsequent PR can be made to the openssl-sys crate to allow propagation of the openssl dir to this code.

@alexcrichton alexcrichton merged commit 2a397fe into alexcrichton:main Dec 4, 2023
16 checks passed
@DanielSidhion DanielSidhion deleted the configure-openssl-dir branch December 4, 2023 17:30
@DanielSidhion
Copy link
Contributor Author

DanielSidhion commented Dec 4, 2023

Thanks @alexcrichton ! To fully resolve #161 (and also unblock a few builds with nix), I'll also need to make a corresponding PR to openssl-sys to propagate their OPENSSL_DIR env var to this crate. I believe I can only do this once a new release of openssl-src is made. Do you have an idea when the next release will be available?

@alexcrichton
Copy link
Owner

I'll do a release when #217 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion to fetch openssldir from env variable
2 participants