Issue #1316: fixed the seg-fault which occurred if --soloType CB_samT…

…agOut and --soloCBwhitelist None are used together.
alexdobin · Sep 24, 2021 · e49af00 · e49af00
1 parent 4408118
commit e49af00
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,4 @@
+* Issue #1316: fixed the seg-fault which occurred if --soloType CB_samTagOut and --soloCBwhitelist None are used together.
 * Changed Solo summary statistics outputs in Barcodes.stats and Features.stats files.
 * Implemented --soloCBmatchWLtype ParseBio_ED3 to allow multiple mismatches and one insertion+deletion for --soloType CB_UMI_Complex.
 * Implemented Solo BAM tags gx gn: output ';'-separated gene IDs and names for both unique- and multi-gene reads. Note that GX/GN tags are used to output gene ID/name for unique-gene reads.

diff --git a/source/SoloReadBarcode_getCBandUMI.cpp b/source/SoloReadBarcode_getCBandUMI.cpp
@@ -282,7 +282,11 @@ void SoloReadBarcode::getCBandUMI(char **readSeq, char **readQual, uint64 *readL
         matchCBtoWL(cbSeq, cbQual, pSolo.cbWL, cbMatch, cbMatchInd, cbMatchString);
 
         if ( cbMatch==0 || cbMatch==1 ) {
-        	cbSeqCorrected=pSolo.cbWLstr[cbMatchInd[0]];
+            if (pSolo.cbWLyes) {
+        	    cbSeqCorrected = pSolo.cbWLstr[cbMatchInd[0]];
+            } else {
+                cbSeqCorrected = cbSeq; //no WL - no correction
+            };
         } else {
         	cbSeqCorrected="";
         };