Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ioutil with other functions #214

Merged
merged 1 commit into from
Dec 4, 2021

Conversation

aminvakil
Copy link
Contributor

Fixes #213

ioutilDeprecated: ioutil.ReadAll is deprecated, use io.ReadAll instead

ioutil.ReadFile is deprecated, use os.ReadFile instead

ioutilDeprecated: ioutil.ReadAll is deprecated, use io.ReadAll instead

ioutil.ReadFile is deprecated, use os.ReadFile instead
aminvakil added a commit to aminvakil/aur that referenced this pull request Dec 4, 2021
@aminvakil
Copy link
Contributor Author

I'm not a go developer, but this little change fixed the lint issue and tests pass as well:

aminvakil/aur#79

https://github.com/aminvakil/aur/runs/4416569999?check_suite_focus=true

Copy link
Owner

@alexei-led alexei-led left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexei-led alexei-led merged commit cd6983d into alexei-led:master Dec 4, 2021
@aminvakil aminvakil deleted the 0.9.0lint branch December 4, 2021 17:42
@aminvakil
Copy link
Contributor Author

Is there going to be a 0.9.1 release?
Also 0.9.0 has been changed once and it breaks my package as its checksum had been changed.

aminvakil added a commit to aminvakil/aur that referenced this pull request Dec 4, 2021
@alexei-led
Copy link
Owner

Did not plan to release it soon. But can release 0.9.1 if it can help.

@aminvakil
Copy link
Contributor Author

I have cherry-picked the latest commit for my package currently, no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golangci-lint fails on 0.9.0
2 participants