-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change kubectl download site #1007
Conversation
Signed-off-by: YoninL <jiayo125@gmail.com>
Signed-off-by: YoninL <jiayo125@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@Jasstkn Thank you, can you help to merge this PR? I don't have write permission, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
@Jasstkn I'm assuming you've tested this and that's why you approved the PR. I'm merging it, but I haven't tested it or verified it in any way. Hope you're OK with sending a PR to revert this if there's an issue and breakage for users? |
@YoninL has also provided no evidence of testing, he changed this in the UI as you can see from "patch-1" |
@Jasstkn I merged this and did a release, it broke the build and we have a faulty publish: https://github.com/alexellis/arkade/actions/runs/8029701263/job/21936281148 |
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Thanks for fixing the issue, yes, was updating in the UI, sorry I missed some links. |
Change kubectl download site from https://storage.googleapis.com/kubernetes-release/release to https://dl.k8s.io
Description
Change kubectl download site from https://storage.googleapis.com/kubernetes-release/release to https://dl.k8s.io
Motivation and Context
design/approved
by a maintainer (required)According to Deprecate and migrate away from gs://kubernetes-release kubernetes/k8s.io#2396, we should migrate from gs bucket to dl.k8s.io.
Also refer to how minikube is making the change, https://github.com/kubernetes/minikube/pull/15840/files
How Has This Been Tested?
get_test.go is updated.
If updating or adding a new CLI to
arkade get
, run:Types of changes
Documentation
./arkade get --format markdown
./arkade install --help
Checklist:
git commit -s