Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove k10multicluster from downloads #1083

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Jun 5, 2024

Description

  • Removes k10multicluster hopefully in a temporary sense as the v7.0.0 release does not include binaries for it.
    As it is a disabling, rather than removal, the relevant parts of the code have been block commented for the time being

  • Repoints cmctl tool to its new locacation on github

Motivation and Context

How Has This Been Tested?

e2e-url-checker now runs green

The k10multicluster testing is a bit negative, owing to this being a removal:

➜  arkade git:(disableK10multicluster) make build
go build
➜  arkade git:(disableK10multicluster) ./arkade get k10multicluster
Error: tool k10multicluster not found
➜  arkade git:(disableK10multicluster) ./hack/test-tool.sh k10multicluster
+ ./arkade get k10multicluster --arch arm64 --os darwin --quiet
Error: tool k10multicluster not found
+ ./arkade get k10multicluster --arch x86_64 --os darwin --quiet
Error: tool k10multicluster not found
+ ./arkade get k10multicluster --arch x86_64 --os linux --quiet
Error: tool k10multicluster not found
+ ./arkade get k10multicluster --arch aarch64 --os linux --quiet
Error: tool k10multicluster not found
+ ./arkade get k10multicluster --arch x86_64 --os mingw --quiet
Error: tool k10multicluster not found

cmctl location change:

➜  arkade git:(disableK10multicluster) make build                                                     
go build
➜  arkade git:(disableK10multicluster) ./hack/test-tool.sh cmctl                                      
+ ./arkade get cmctl --arch arm64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/cmctl
/Users/rgee0/.arkade/bin/cmctl: Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/cmctl
+ echo

+ ./arkade get cmctl --arch x86_64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/cmctl
/Users/rgee0/.arkade/bin/cmctl: Mach-O 64-bit executable x86_64
+ rm /Users/rgee0/.arkade/bin/cmctl
+ echo

+ ./arkade get cmctl --arch x86_64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/cmctl
/Users/rgee0/.arkade/bin/cmctl: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=DSNszFe7snPY457Rb-u0/r2MAsc3CBMB_Yf51mygd/D_5fU4N3ds1FygkvS9Bv/6OETL5AFf38M-qjn8yUx, stripped
+ rm /Users/rgee0/.arkade/bin/cmctl
+ echo

+ ./arkade get cmctl --arch aarch64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/cmctl
/Users/rgee0/.arkade/bin/cmctl: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=nOaMMTseeIShIxKNkDoQ/p0Q21wX8ZP6P05oTwfjC/0Oo0PuK-VkO-DHSmhB3U/imrswImJGEt3gowkVI1X, stripped
+ rm /Users/rgee0/.arkade/bin/cmctl
+ echo

+ ./arkade get cmctl --arch x86_64 --os mingw --quiet
+ file /Users/rgee0/.arkade/bin/cmctl.exe
/Users/rgee0/.arkade/bin/cmctl.exe: PE32+ executable (console) x86-64, for MS Windows
+ rm /Users/rgee0/.arkade/bin/cmctl.exe
+ echo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

rgee0 added 2 commits June 5, 2024 18:12
Signed-off-by: Richard Gee <richard@technologee.co.uk>
Signed-off-by: Richard Gee <richard@technologee.co.uk>
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit f5bad4a into alexellis:master Jun 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The cmctl and kubectl_cert-manager binaries have been moved
2 participants