Add no-dco label before closing no_newbies PRs

In a PR raised on the openfaas/faasd repo, the no-dco label
wasn't added, when it should have been. If the PR was re-
opened then it may be merged in error, even without the DCO.

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>

handler/hacktoberfest_handler.go

@@ -45,20 +45,19 @@ func HandleFirstTimerPR(req types.PullRequestOuter, contributingURL string, conf
 
 			fmt.Println(fmt.Sprintf("Request to close issue #%d was successful.\n", req.PullRequest.Number))
 
+			body := firstTimerComment(contributingURL)
+			if err = createPullRequestComment(ctx, body, req, client); err != nil {
+				log.Fatalf("unable to add comment on PR %d: %s", req.PullRequest.Number, err)
+				return true, err
+			}
+
 			_, res, assignLabelErr := client.Issues.AddLabelsToIssue(ctx, req.Repository.Owner.Login, req.Repository.Name, req.PullRequest.Number,
 				[]string{invalidLabel})
 			if assignLabelErr != nil {
 				log.Fatalf("%s limit: %d, remaining: %d", assignLabelErr, res.Limit, res.Remaining)
 				return true, assignLabelErr
 			}
 
-			body := firstTimerComment(contributingURL)
-
-			if err = createPullRequestComment(ctx, body, req, client); err != nil {
-				log.Fatalf("unable to add comment on PR %d: %s", req.PullRequest.Number, err)
-				return true, err
-			}
-
 			return true, nil
 		}
 	}

main.go

@@ -134,24 +134,28 @@ func handleEvent(eventType string, bytesIn []byte, config config.Config) error {
 
 		if req.Action != handler.ClosedConstant && req.PullRequest.State != handler.ClosedConstant {
 			contributingURL := getContributingURL(derekConfig.ContributingURL, req.Repository.Owner.Login, req.Repository.Name)
+
+			if handler.EnabledFeature(dcoCheck, derekConfig) {
+				handler.HandlePullRequest(req, contributingURL, config)
+			}
+
+			if handler.EnabledFeature(prDescriptionRequired, derekConfig) {
+				handler.VerifyPullRequestDescription(req, contributingURL, config)
+			}
+
 			if handler.EnabledFeature(noNewbies, derekConfig) {
 				isSpamPR, _ := handler.HandleFirstTimerPR(req, contributingURL, config)
 				if isSpamPR {
 					return nil
 				}
 			}
+
 			if handler.EnabledFeature(hacktoberfest, derekConfig) {
 				isSpamPR, _ := handler.HandleHacktoberfestPR(req, contributingURL, config)
 				if isSpamPR {
 					return nil
 				}
 			}
-			if handler.EnabledFeature(dcoCheck, derekConfig) {
-				handler.HandlePullRequest(req, contributingURL, config)
-			}
-			if handler.EnabledFeature(prDescriptionRequired, derekConfig) {
-				handler.VerifyPullRequestDescription(req, contributingURL, config)
-			}
 		}
 		break