Add feature release_notes to generate release notes #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature enables notes to be collected from all merged/closed PRs since the last release. The notes are then set/saved on the release body field. Tested in a console application outside of Derek and e2e with Derek operating against the openfaas/org-tester repo. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Describes the new feature for release_notes and why the new permissions are required. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Documents logic and adds tests for the basic scenarios. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Tests help show the bounding behaviour when only one release is present. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
alexellis
changed the title
|
GitHub behaviour:
With Derek's feature enabled:
|
|
Notifying ".CUSTOMERS" moby - @thaJeztah PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature enables notes to be collected from all merged/closed
PRs since the last release. The notes are then set/saved on the
release body field.
Motivation and Context
Closes: #89
How Has This Been Tested?
Tested in a console application outside of Derek and e2e with
Derek operating against the openfaas/org-tester repo.
Types of changes
Users must opt-in to use this feature, but it requests new permissions:
User guide has been updated, to get this feature add
release_notesunderfeatures:in.DEREK.ymlChecklist:
git commit -s