-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to using go modules #161
Conversation
Sorry for the multiple commits. I've been trying to debug, and travis is doing weird things with the I've reached my quota for debugging tonight, but hopefully I'll be recharged later and can revisit this. Another option is to remove the vendor dir as a whole, but I'm trying to solve this with making as few changes from existing workflow as possible. |
Fix #160 Signed-off-by: Matti R <matti@mdranta.net>
Ah, I shouldn't debug so late at night. I wasn't actually adding in the modules.txt file which was what was missing. This PR is now good to go. |
Why did so many files change for a dep - mod update? |
Primary cause is Note: I updated as few things as possible, for example |
This PR doesn't adhere to the |
Thank you - this PR is wanted. @LucasRoesler bumped into something similar with logrus and faas/faas-cli. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
FYI this didn't build for me after merging into master:
What should I do? |
The ./build folder is generated by OpenFaaS, and the go toolchain is picking it up, when it shouldn't. I couldn't find a way to exclude a folder from |
could it be a file system case-sensitivity issue? i don't understand the statement about |
An older Derek version was in |
Description
Switches from
dep
to use go modules.Motivation and Context
By switching to go modules it would bring dependency management to align with go ecosystem.
Fixes #160
How Has This Been Tested?
make build test
succeeded.Types of changes
Checklist:
git commit -s