Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cake-build to customer list #162

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Add cake-build to customer list #162

merged 1 commit into from
Oct 1, 2020

Conversation

pascalberger
Copy link
Contributor

Signed-off-by: Pascal Berger pascal.berger@gmail.com

Description

Add cake-build to customer list

Motivation and Context

  • I have raised an issue to propose this change (required)

We would like to try out Derek on the https://github.com/cake-build/website repository.

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pascalberger
Add cake-build to customer list
f0cc74a 
Signed-off-by: Pascal Berger <pascal.berger@gmail.com>
@derek derek bot added the new-contributor label Oct 1, 2020
@pascalberger
Copy link
Contributor Author

If you prefer to have an issue created for this please let me know and I'll create it. I assumed since it is not a contribution to code that you don't require an issue.

@pascalberger pascalberger mentioned this pull request Oct 1, 2020
Merged
alexellis
alexellis approved these changes Oct 1, 2020
View reviewed changes
Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@alexellis alexellis merged commit bce4abe into alexellis:master Oct 1, 2020
@alexellis
Copy link
Owner

Merged 👌

@pascalberger pascalberger deleted the feature/cake-build branch October 1, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis approved these changes

Assignees
No one assigned
Labels
new-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pascalberger @alexellis