-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GitHub Actions #173
Conversation
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Travis will not work :) |
Can you test in your own repo and confirm if the GHCR image looks as expected? |
for the ci workflow: https://github.com/cpanato/derek/actions/runs/657599793 for the publish workflow: https://github.com/cpanato/derek/actions/runs/657609156 images are available:
running the image:
|
Please could you use GHCR instead of Docker Hub? |
@alexellis updated to use GHCR instead of docker.io |
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
platforms: linux/amd64,linux/arm64 | ||
push: true | ||
tags: | | ||
ghcr.io/${{ steps.get_repo_owner.outputs.repo_owner }}/derek:${{ steps.get_tag.outputs.TAG }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change this now, but if github.repository_owner
gives the same value as steps.get_repo_owner.outputs.repo_owner
, then we could probably remove that step in the future. I think github.repository_owner
must be new, because we didn't find it when looking before? cc @utsavanand2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i thought that, but i saw an existing example in another openfaas repo that I followed, but I think we can update all to use the envs the github provide, including the tag
I can open a follow up or if you would like
Let's see if it worked? https://github.com/alexellis/derek/actions/runs/658244376 |
And the release build -> https://github.com/alexellis/derek/actions/runs/658249877 |
Description
Remove travis-ci and create GitHub Actions workflows for build/test and publish the images
Need to set up the appropriate credentials in the repository to make the publish workflow work properly.
/assign @alexellis
Motivation and Context
Fixes Migrate to GitHub Actions #170
How Has This Been Tested?
Types of changes
Checklist:
git commit -s