Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use repo default branch #174

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Conversation

cpanato
Copy link
Contributor

@cpanato cpanato commented Mar 19, 2021

Description

Pushing and opening this PR to override the PR #171

For context see #171

Motivation and Context

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

Tested deploying the Derek and configuring it.

  • with private repo and public repo, using master branch as default and also using another branch name as default (in this case tested with main branch as default)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cpanato cpanato mentioned this pull request Mar 19, 2021
12 tasks
@cpanato
Copy link
Contributor Author

cpanato commented Mar 19, 2021

this PR just update the branch and there are no code changes.

@alexellis can you update the repo configuration to remove the status check for Travis and add the ones for GitHub action?
thanks!

@derek
Copy link

derek bot commented Apr 21, 2021

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

@derek derek bot added the no-dco label Apr 21, 2021
@alexellis
Copy link
Owner

Please fix your commits for Derek - ideally rebase / squash them.

https://www.youtube.com/watch?v=8j0H6urZ-bU

Signed-off-by: jolheiser <john.olheiser@gmail.com>
@derek derek bot removed the no-dco label Apr 22, 2021
@cpanato
Copy link
Contributor Author

cpanato commented Apr 22, 2021

@alexellis done

Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexellis alexellis merged commit 16743cb into alexellis:master Apr 22, 2021
@alexellis
Copy link
Owner

Thanks for this.

Can you ping me when the Docker image is up? https://github.com/alexellis/derek/releases/tag/0.11.0 I'll deploy to the SaaS server then.

@jolheiser jolheiser mentioned this pull request Apr 27, 2021
3 tasks
@cpanato cpanato deleted the default-branch branch September 19, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants