-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leader-election-role rules #43
Conversation
Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project. Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken. 💡 Shall we fix this?This will only take a few moments. First, clone your fork and checkout this branch using the git CLI. Next, set up your real name and email address:
Finally, run one of these commands to add the "Signed-off-by" line to your commits. If you only have one commit so far then run: Check that the message has been added properly by running "git log". |
Give permission to the leader-extension-role to access coordination.k8s.io/leases Signed-off-by: Nicolas Surleraux <nicolas.surleraux@railnova.eu>
63ad42f
to
4ec9a84
Compare
Thanks for signing off. We will need more details of the testing along with the manifests being regenerated. See the Makefile targets. |
Signed-off-by: Nicolas Surleraux <nicolas.surleraux@railnova.eu>
I just regenerated the manifest using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Thanks @nsurleraux-railnova I'll get this merged. |
Description
Give permission to the leader-extension-role to access coordination.k8s.io/leases
Which issue # does this fix? And was it approved before you worked on it?
Checklist:
Note: if the PR is for a typo, please close it and raise an issue instead.
Are you a GitHub Sponsor (Yes/No?)
Pull Requests from sponsors get prioritised and a quicker response.
Check at: https://github.com/sponsors/alexellis
How Has This Been Tested?
Tested on our production EKS cluster.
How are existing users impacted? What migration steps/scripts do we need?
No foreseen impact.
Checklist:
I have:
git commit -s