Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kubeconfig not found #45

Merged

Conversation

fredleger
Copy link
Contributor

Description

Which issue # does this fix? And was it approved before you worked on it?

Checklist:

Note: if the PR is for a typo, please close it and raise an issue instead.

Are you a GitHub Sponsor (Yes/No?)

Pull Requests from sponsors get prioritised and a quicker response.

Check at: https://github.com/sponsors/alexellis

  • Yes
  • No

How Has This Been Tested?

  • Forked repo
  • added automountServiceAccountToken: true
  • used the forked repo in argocd to deploy to 3 clusters in 1.23
  • checked that it fixed the error (and of course it did)

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • read the CONTRIBUTION guide
  • signed-off my commits with git commit -s
  • added unit tests

Copy link

derek bot commented Apr 4, 2024

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

Signed-off-by: Frederic Leger <frederic@webofmars.com>
@derek derek bot removed the no-dco label Apr 4, 2024
@alexellis
Copy link
Owner

I haven't run into this problem, but don't use the tool myself. I'll take it from you that you've tested this and that it fixes your issues for your company.

Do you need a release?

@fredleger
Copy link
Contributor Author

thanks @alexellis
i confirm it's in production for a week now on 3 clusters and it does work
would be nice in order to have a clear tag on the history instead of a commit id.

thanks for the great work

Copy link
Owner

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 77b2b0b into alexellis:master May 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants