Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice Support #204

Merged
merged 26 commits into from
Aug 1, 2023
Merged

Voice Support #204

merged 26 commits into from
Aug 1, 2023

Conversation

FaiThiX
Copy link
Contributor

@FaiThiX FaiThiX commented Jul 15, 2023

Tested on Windows 11 22621.1992 and Ubuntu 22.04

@FaiThiX FaiThiX mentioned this pull request Jul 15, 2023
@FaiThiX
Copy link
Contributor Author

FaiThiX commented Jul 15, 2023

addressing #33

src/commands/voice.js Outdated Show resolved Hide resolved
src/commands/voice.js Outdated Show resolved Hide resolved
src/commands/voice.js Outdated Show resolved Hide resolved
src/commands/voice.js Outdated Show resolved Hide resolved
src/commands/voice.js Outdated Show resolved Hide resolved
src/commands/voice.js Outdated Show resolved Hide resolved
@alexemanuelol
Copy link
Owner

alexemanuelol commented Aug 1, 2023

Add the following to the PR:

--- a/src/util/CreateInstanceFile.js
+++ b/src/util/CreateInstanceFile.js
@@ -94,6 +94,13 @@ module.exports = (client, guild) => {
                 if (!instance.notificationSettings.hasOwnProperty(key)) {
                     instance.notificationSettings[key] = value;
                 }
+                else {
+                    for (const [setting, settingValue] of Object.entries(value)) {
+                        if (!instance.notificationSettings[key].hasOwnProperty(setting)) {
+                            instance.notificationSettings[key][setting] = settingValue;
+                        }
+                    }
+                }
             }
         }

Otherwise the voice setting for each notification setting wont be found

@alexemanuelol
Copy link
Owner

alexemanuelol commented Aug 1, 2023

Add:

--- a/package.json
+++ b/package.json
@@ -28,6 +28,7 @@
         "discord-api-types": "^0.37.37",
         "discord.js": "^14.8.0",
         "ffmpeg": "^0.0.4",
+        "ffmpeg-static": "^5.1.0",
         "fuse.js": "^6.6.2",
         "gm": "^1.25.0",
         "jimp": "^0.22.7",

@alexemanuelol alexemanuelol merged commit ec618e0 into alexemanuelol:master Aug 1, 2023
@FaiThiX FaiThiX deleted the voice branch September 19, 2023 14:59
@FaiThiX FaiThiX restored the voice branch September 19, 2023 14:59
@FaiThiX FaiThiX deleted the voice branch September 19, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants