test: add test (shouldn't overflow when coloring already colored large text) #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/test.js
Outdated
| try { | ||
| pc.blue(pc.red("x").repeat(10000)) | ||
| assert(true) | ||
| } catch { |
There was a problem hiding this comment.
Omitting (error) only works in newer Node.js versions. Could you please add (error) so the rest of pipelines would go green? Thanks
There was a problem hiding this comment.
Oops!
Didn't check the CI tests.
Thank you!
Now everything is green :)
…e text) - add error statements in case of lower node version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to above PR, there's no more call stack overflow when coloring already colored long string.
I added some tests to compensate a bit.
I wanted to add tests to the Vite project, but it was pretty tricky, so I made a PR here.
Following's related PR on Vite project.
As-Is (Test fail)
To-Be (Test success)