test: migrate message source map tests from Python to JS

Migrate the remaining source map tests in the `test/message` folder from Python to JS. Fixes: nodejs#47707 test: migrate message source map tests from Python to JS PR-URL: nodejs#49238 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
alexfernandez · Nov 1, 2023 · c8442ef · c8442ef
1 parent 09093ad
commit c8442ef
Show file tree

Hide file tree

Showing 20 changed files with 65 additions and 55 deletions.
diff --git a/test/fixtures/source-map/output/source_map_enclosing_function.js b/test/fixtures/source-map/output/source_map_enclosing_function.js
@@ -0,0 +1,7 @@
+// Flags:  --enable-source-maps
+
+'use strict';
+require('../../../common');
+Error.stackTraceLimit = 5;
+
+require('../enclosing-call-site-min.js');
diff --git a/...message/source_map_enclosing_function.out → ...ut/source_map_enclosing_function.snapshot b/...message/source_map_enclosing_function.out → ...ut/source_map_enclosing_function.snapshot
@@ -2,6 +2,7 @@
   throw err
   ^
 
+
 Error: an error!
     at functionD (*enclosing-call-site.js:16:17)
     at functionC (*enclosing-call-site.js:10:3)

diff --git a/...essage/source_map_reference_error_tabs.js → ...output/source_map_reference_error_tabs.js b/...essage/source_map_reference_error_tabs.js → ...output/source_map_reference_error_tabs.js
@@ -1,7 +1,7 @@
 // Flags:  --enable-source-maps
 
 'use strict';
-require('../common');
+require('../../../common');
 Error.stackTraceLimit = 2;
 
-require('../fixtures/source-map/tabs.js');
+require('../tabs.js');
diff --git a/test/fixtures/source-map/output/source_map_reference_error_tabs.snapshot b/test/fixtures/source-map/output/source_map_reference_error_tabs.snapshot
@@ -0,0 +1,10 @@
+*tabs.coffee:26
+	alert "I knew it!"
+	^
+
+
+ReferenceError: alert is not defined
+    at Object.<anonymous> (*tabs.coffee:26:2)
+    at Object.<anonymous> (*tabs.coffee:1:14)
+
+Node.js *
diff --git a/...ge/source_map_sourcemapping_url_string.js → ...ut/source_map_sourcemapping_url_string.js b/...ge/source_map_sourcemapping_url_string.js → ...ut/source_map_sourcemapping_url_string.js
@@ -1,11 +1,11 @@
 // Flags:  --enable-source-maps
 
 'use strict';
-require('../common');
+require('../../../common');
 Error.stackTraceLimit = 2;
 
 try {
-  require('../fixtures/source-map/typescript-sourcemapping_url_string');
+  require('../typescript-sourcemapping_url_string');
 } catch (err) {
   setTimeout(() => {
     console.info(err);

diff --git a/test/fixtures/source-map/output/source_map_sourcemapping_url_string.snapshot b/test/fixtures/source-map/output/source_map_sourcemapping_url_string.snapshot
@@ -0,0 +1,3 @@
+Error: an exception.
+    at Object.<anonymous> (*typescript-sourcemapping_url_string.ts:3:7)
+    at Module._compile (node:internal*modules*cjs*loader:1241:14)
diff --git a/test/message/source_map_throw_catch.js → ...urce-map/output/source_map_throw_catch.js b/test/message/source_map_throw_catch.js → ...urce-map/output/source_map_throw_catch.js
@@ -1,11 +1,11 @@
 // Flags:  --enable-source-maps
 
 'use strict';
-require('../common');
+require('../../../common');
 Error.stackTraceLimit = 2;
 
 try {
-  require('../fixtures/source-map/typescript-throw');
+  require('../typescript-throw');
 } catch (err) {
   setTimeout(() => {
     console.info(err);

diff --git a/test/fixtures/source-map/output/source_map_throw_catch.snapshot b/test/fixtures/source-map/output/source_map_throw_catch.snapshot
@@ -0,0 +1,4 @@
+reachable
+Error: an exception
+    at branch (*typescript-throw.ts:18:11)
+    at Object.<anonymous> (*typescript-throw.ts:24:1)
diff --git a/test/message/source_map_throw_icu.js → ...source-map/output/source_map_throw_icu.js b/test/message/source_map_throw_icu.js → ...source-map/output/source_map_throw_icu.js
@@ -1,7 +1,7 @@
 // Flags: --enable-source-maps
 
 'use strict';
-require('../common');
+require('../../../common');
 Error.stackTraceLimit = 2;
 
-require('../fixtures/source-map/icu');
+require('../icu');
diff --git a/test/fixtures/source-map/output/source_map_throw_icu.snapshot b/test/fixtures/source-map/output/source_map_throw_icu.snapshot
@@ -0,0 +1,10 @@
+*icu.jsx:3
+    ("あ 🐕 🐕", throw Error("an error"));
+     ^
+
+
+Error: an error
+    at Object.createElement (*icu.jsx:3:23)
+    at Object.<anonymous> (*icu.jsx:9:5)
+
+Node.js *
diff --git a/test/fixtures/source-map/output/source_map_throw_set_immediate.js b/test/fixtures/source-map/output/source_map_throw_set_immediate.js
@@ -0,0 +1,5 @@
+// Flags:  --enable-source-maps
+
+'use strict';
+require('../../../common');
+require('../uglify-throw');
diff --git a/test/fixtures/source-map/output/source_map_throw_set_immediate.snapshot b/test/fixtures/source-map/output/source_map_throw_set_immediate.snapshot
@@ -0,0 +1,11 @@
+*uglify-throw-original.js:5
+  throw Error('goodbye');
+  ^
+
+
+Error: goodbye
+    at Hello (*uglify-throw-original.js:5:9)
+    at Immediate.<anonymous> (*uglify-throw-original.js:9:3)
+    at process.processImmediate (node:internal*timers:478:21)
+
+Node.js *
diff --git a/test/message/source_map_enclosing_function.js b/test/message/source_map_enclosing_function.js
diff --git a/test/message/source_map_reference_error_tabs.out b/test/message/source_map_reference_error_tabs.out
diff --git a/test/message/source_map_sourcemapping_url_string.out b/test/message/source_map_sourcemapping_url_string.out
diff --git a/test/message/source_map_throw_catch.out b/test/message/source_map_throw_catch.out
diff --git a/test/message/source_map_throw_icu.out b/test/message/source_map_throw_icu.out
diff --git a/test/message/source_map_throw_set_immediate.js b/test/message/source_map_throw_set_immediate.js
diff --git a/test/message/source_map_throw_set_immediate.out b/test/message/source_map_throw_set_immediate.out
diff --git a/test/parallel/test-node-output-sourcemaps.mjs b/test/parallel/test-node-output-sourcemaps.mjs
@@ -30,9 +30,15 @@ describe('sourcemaps output', { concurrency: true }, () => {
   const tests = [
     { name: 'source-map/output/source_map_disabled_by_api.js' },
     { name: 'source-map/output/source_map_enabled_by_api.js' },
+    { name: 'source-map/output/source_map_enclosing_function.js' },
     { name: 'source-map/output/source_map_eval.js' },
     { name: 'source-map/output/source_map_no_source_file.js' },
+    { name: 'source-map/output/source_map_reference_error_tabs.js' },
+    { name: 'source-map/output/source_map_sourcemapping_url_string.js' },
+    { name: 'source-map/output/source_map_throw_catch.js' },
     { name: 'source-map/output/source_map_throw_first_tick.js' },
+    { name: 'source-map/output/source_map_throw_icu.js' },
+    { name: 'source-map/output/source_map_throw_set_immediate.js' },
   ];
   for (const { name, transform } of tests) {
     it(name, async () => {