fix: Allow prefixUrl to work #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mnkras
commented
Aug 1, 2023
| @@ -175,7 +180,7 @@ describe('fetch request', () => { | |||
|
|
|||
| }); | |||
|
|
|||
| it.only("sends own content-type header", async () => { | |||
| it("sends own content-type header", async () => { | |||
There was a problem hiding this comment.
the only meant none of the other tests in this file ran
alexghr
reviewed
Aug 2, 2023
| @@ -175,7 +180,7 @@ describe('fetch request', () => { | |||
|
|
|||
| }); | |||
|
|
|||
| it.only("sends own content-type header", async () => { | |||
| it("sends own content-type header", async () => { | |||
src/test/fetch.request.test.ts
Outdated
Comment on lines
51
to
57
| it('merges query string parameters', async () => { | ||
| expect.assertions(1); | ||
| interceptor.intercept('/', 'get').query({ foo: '123', bar: '456' }).reply(200); | ||
|
|
||
| const fetch = createFetch(got.extend({ searchParams: { bar: '456' } })); | ||
| await assert200(fetch(url('/', { foo: '123' }))); | ||
| }); |
There was a problem hiding this comment.
I think disabling this might be problematic because I'd expect people to use it to add access tokens/API keys as a base on their clients 🤔
alexghr
reviewed
Aug 2, 2023
There was a problem hiding this comment.
How about doing the URL parsing like below and restoring the code that sends searchParams as a separate entity, restoring the deleted test and adding an extra test for prefixUrl + search params merging:
it("merges query string parameters with a prefix URL", async () => {
expect.assertions(1);
interceptor
.intercept("/", "get")
.query({ foo: "123", bar: "456" })
.reply(200);
const fetch = createFetch(
got.extend({
prefixUrl: ORIGIN,
searchParams: { bar: "456" },
})
);
await assert200(fetch("/?foo=123"));
});
Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com>
|
@alexghr Just wanted to check in on this |
|
@alexghr checking in again, would love to get this merged |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
## [4.0.5](v4.0.4...v4.0.5) (2024-07-19) ### Bug Fixes * Allow prefixUrl to work ([#370](#370)) ([c27a53a](c27a53a))
|
🎉 This PR is included in version 4.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is most certainly a hack, but I was trying to maintain the current behaviour.
#369
I can also port this to main