Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming changes according to Schwab_Trader_API_-_Streamer_Guide.pdf #127

Merged
merged 7 commits into from
Jul 2, 2024

Conversation

jacabreragt
Copy link
Contributor

Field names were changed to match the Streamer Guide document. Timesales and News services were removed and Screener Service added. Implemented LOGOUT functionality and for each service ADD feature is implemented as well.

@jacabreragt
Copy link
Contributor Author

Found out that ADD functions need fields to be sent in the request to the websocket so fixed that.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (d14175a) to head (4c8c5b7).
Report is 7 commits behind head on main.

Current head 4c8c5b7 differs from pull request most recent head 1ee2924

Please upload reports for the commit 1ee2924 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   98.87%   98.55%   -0.32%     
==========================================
  Files          18       18              
  Lines        2216     2214       -2     
  Branches      226      229       +3     
==========================================
- Hits         2191     2182       -9     
- Misses         17       21       +4     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 98.55% <100.00%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacabreragt
Copy link
Contributor Author

Test cases related to the streaming module has been updated and added to reflect all the changes.

Copy link
Owner

@alexgolec alexgolec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial round

schwab/streaming.py Outdated Show resolved Hide resolved
schwab/streaming.py Outdated Show resolved Hide resolved
schwab/streaming.py Outdated Show resolved Hide resolved
schwab/streaming.py Outdated Show resolved Hide resolved
schwab/streaming.py Outdated Show resolved Hide resolved
@alexgolec
Copy link
Owner

@jacabreragt jacabreragt requested a review from alexgolec June 21, 2024 22:38
schwab/streaming.py Outdated Show resolved Hide resolved
schwab/streaming.py Show resolved Hide resolved
schwab/streaming.py Show resolved Hide resolved
schwab/streaming.py Outdated Show resolved Hide resolved
schwab/streaming.py Show resolved Hide resolved
tests/streaming_test.py Show resolved Hide resolved
@alexgolec alexgolec linked an issue Jun 25, 2024 that may be closed by this pull request
@jacabreragt jacabreragt requested a review from alexgolec June 26, 2024 23:47
docs/streaming.rst Outdated Show resolved Hide resolved
schwab/streaming.py Outdated Show resolved Hide resolved
@jacabreragt jacabreragt requested a review from alexgolec July 1, 2024 01:01
@alexgolec alexgolec merged commit 5a68b16 into alexgolec:main Jul 2, 2024
10 checks passed
@alexgolec
Copy link
Owner

Thanks for this PR!

@jacabreragt jacabreragt deleted the streaming branch July 2, 2024 13:34
#: UNKNOWN
FIELD_15 = 15
#: Current percent change
FUTURE_CHANGE_PERCENT = 20
Copy link

@mm0 mm0 Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this may have been done accidentally since other fields were modified where it does make sense to have the FUTURE prefix. Would it make more sense to keep this consistent with other contract/ticker types?

MARK_CHANGE_PERCENT instead of FUTURE_CHANGE_PERCENT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LevelOneFuturesFields are not complete
3 participants