Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caveats #202

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Caveats #202

merged 3 commits into from
Jul 7, 2024

Conversation

wiseodd
Copy link
Collaborator

@wiseodd wiseodd commented Jul 4, 2024

Closes #147
Closes #193

@runame please review and feel free to recommend the wording about the class-dim caveat.

@wiseodd wiseodd added bug Something isn't working documentation Improvements or additions to documentation labels Jul 4, 2024
@wiseodd wiseodd added this to the 0.2 milestone Jul 4, 2024
@wiseodd wiseodd requested a review from runame July 4, 2024 19:52
@wiseodd wiseodd self-assigned this Jul 4, 2024
@wiseodd wiseodd linked an issue Jul 6, 2024 that may be closed by this pull request
Copy link
Collaborator

@runame runame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wiseodd wiseodd merged commit ff5d068 into main Jul 7, 2024
3 checks passed
@wiseodd wiseodd deleted the caveats branch July 7, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
2 participants